X-Git-Url: https://mograsim.net/gitweb/?a=blobdiff_plain;f=net.mograsim.logic.model%2Fsrc%2Fnet%2Fmograsim%2Flogic%2Fmodel%2Fmodel%2Fcomponents%2Fsubmodels%2FSubmodelComponent.java;h=9388e2fb09fdc7e51ba8370f1b2c76e5700397f3;hb=fb26dcd2084072f24b96187e98bd82fb186eada6;hp=ffe6ed63fdcea8247186541ef879df7219411a3b;hpb=92862c4723c5eff22257e8de06166a124efb5d77;p=Mograsim.git

diff --git a/net.mograsim.logic.model/src/net/mograsim/logic/model/model/components/submodels/SubmodelComponent.java b/net.mograsim.logic.model/src/net/mograsim/logic/model/model/components/submodels/SubmodelComponent.java
index ffe6ed63..9388e2fb 100644
--- a/net.mograsim.logic.model/src/net/mograsim/logic/model/model/components/submodels/SubmodelComponent.java
+++ b/net.mograsim.logic.model/src/net/mograsim/logic/model/model/components/submodels/SubmodelComponent.java
@@ -115,7 +115,7 @@ public abstract class SubmodelComponent extends ModelComponent
 		this.supermodelPins = new HashMap<>();
 		this.supermodelMovablePinsUnmodifiable = Collections.unmodifiableMap(supermodelPins);
 		this.supermodelUnmovablePinsUnmodifiable = Collections.unmodifiableMap(supermodelPins);
-		this.submodelInterface = new SubmodelInterface(submodelModifiable, SUBMODEL_INTERFACE_NAME);
+		this.submodelInterface = new SubmodelInterface(submodelModifiable);
 
 		this.submodelScale = 1;
 		this.maxVisibleRegionFillRatioForAlpha0 = 0.8;
@@ -167,7 +167,7 @@ public abstract class SubmodelComponent extends ModelComponent
 		default:
 			throw new IllegalArgumentException("Unknown enum constant: " + supermodelPin.usage);
 		}
-		MovablePin submodelPin = new MovablePin(model, submodelInterface, name, supermodelPin.logicWidth, submodelPinUsage,
+		MovablePin submodelPin = new MovablePin(submodelModifiable, submodelInterface, name, supermodelPin.logicWidth, submodelPinUsage,
 				supermodelPin.getRelX() / submodelScale, supermodelPin.getRelY() / submodelScale);
 
 		submodelPin.addPinMovedListener(p ->
@@ -429,14 +429,28 @@ public abstract class SubmodelComponent extends ModelComponent
 
 	// serializing
 
+	/**
+	 * {@link SubmodelComponent}'s implementation of {@link ModelComponent#getIDForSerializing(IdentifyParams)} returns "submodel". It is
+	 * recommended to override this behaviour.
+	 * 
+	 * @see ModelComponent#getIDForSerializing(IdentifyParams)
+	 * @see ModelComponent#getParamsForSerializing(IdentifyParams)
+	 */
 	@Override
 	public String getIDForSerializing(IdentifyParams idParams)
 	{
 		return "submodel";// TODO what ID?
 	}
 
+	/**
+	 * {@link SubmodelComponent}'s implementation of {@link ModelComponent#getParamsForSerializing(IdentifyParams)} returns an instance of
+	 * {@link SubmodelComponentParams}. It is recommended to override this behaviour.
+	 * 
+	 * @see ModelComponent#getIDForSerializing(IdentifyParams)
+	 * @see ModelComponent#getParamsForSerializing(IdentifyParams)
+	 */
 	@Override
-	public SubmodelComponentParams getParamsForSerializing(IdentifyParams idParams)
+	public Object getParamsForSerializing(IdentifyParams idParams)
 	{
 		return SubmodelComponentSerializer.serialize(this, idParams);
 	}