X-Git-Url: https://mograsim.net/gitweb/?a=blobdiff_plain;f=net.mograsim.logic.model.am2900%2Fsrc%2Fnet%2Fmograsim%2Flogic%2Fmodel%2Fam2900%2Fcomponents%2Fam2910%2FGUIAm2910RegCntr.java;h=49e4a4ca1814f1913466f6779d457eebd951c48c;hb=30b24889d4ae001113c6cac543fb8c29d15d0ff2;hp=3c1ca2e901aa58ea2bc541330d239b0bed7bb919;hpb=c9cca272f312bdea6cf661e861508fca2431a9d2;p=Mograsim.git

diff --git a/net.mograsim.logic.model.am2900/src/net/mograsim/logic/model/am2900/components/am2910/GUIAm2910RegCntr.java b/net.mograsim.logic.model.am2900/src/net/mograsim/logic/model/am2900/components/am2910/GUIAm2910RegCntr.java
index 3c1ca2e9..49e4a4ca 100644
--- a/net.mograsim.logic.model.am2900/src/net/mograsim/logic/model/am2900/components/am2910/GUIAm2910RegCntr.java
+++ b/net.mograsim.logic.model.am2900/src/net/mograsim/logic/model/am2900/components/am2910/GUIAm2910RegCntr.java
@@ -13,6 +13,7 @@ import net.mograsim.logic.core.wires.Wire.ReadWriteEnd;
 import net.mograsim.logic.model.model.ViewModelModifiable;
 import net.mograsim.logic.model.model.components.atomic.SimpleRectangularHardcodedGUIComponent;
 import net.mograsim.logic.model.model.wires.Pin;
+import net.mograsim.logic.model.model.wires.PinUsage;
 import net.mograsim.logic.model.serializing.IndirectGUIComponentCreator;
 import net.mograsim.logic.model.snippets.symbolrenderers.PinNamesSymbolRenderer.PinNamesParams.Position;
 
@@ -22,16 +23,16 @@ public class GUIAm2910RegCntr extends SimpleRectangularHardcodedGUIComponent
 	{
 		super(model, name, "Register/\nCounter");
 		setSize(40, 40);
-		addPin(new Pin(this, "D", 12, 20, 0), Usage.INPUT, Position.BOTTOM);
-		addPin(new Pin(this, "_RLD", 1, 0, 5), Usage.INPUT, Position.RIGHT);
-		addPin(new Pin(this, "RWE", 1, 0, 20), Usage.INPUT, Position.RIGHT);
-		addPin(new Pin(this, "RDEC", 1, 0, 30), Usage.INPUT, Position.RIGHT);
-		addPin(new Pin(this, "C", 1, 40, 20), Usage.INPUT, Position.LEFT);
-		addPin(new Pin(this, "Y", 12, 20, 40), Usage.OUTPUT, Position.TOP);
+		addPin(new Pin(this, "D", 12, PinUsage.INPUT, 20, 0), Position.BOTTOM);
+		addPin(new Pin(this, "_RLD", 1, PinUsage.INPUT, 0, 5), Position.RIGHT);
+		addPin(new Pin(this, "WE", 1, PinUsage.INPUT, 0, 20), Position.RIGHT);
+		addPin(new Pin(this, "DEC", 1, PinUsage.INPUT, 0, 30), Position.RIGHT);
+		addPin(new Pin(this, "C", 1, PinUsage.INPUT, 40, 20), Position.LEFT);
+		addPin(new Pin(this, "Y", 12, PinUsage.OUTPUT, 20, 40), Position.TOP);
 	}
 
 	@Override
-	protected Object recalculate(Object lastState, Map<String, ReadEnd> readEnds, Map<String, ReadWriteEnd> readWriteEnds)
+	public Object recalculate(Object lastState, Map<String, ReadEnd> readEnds, Map<String, ReadWriteEnd> readWriteEnds)
 	{
 		Bit[] QC = (Bit[]) lastState;
 		if (QC == null)
@@ -42,8 +43,8 @@ public class GUIAm2910RegCntr extends SimpleRectangularHardcodedGUIComponent
 
 		ReadEnd D = readEnds.get("D");
 		ReadEnd _RLD = readEnds.get("_RLD");
-		ReadEnd RWE = readEnds.get("RWE");
-		ReadEnd RDEC = readEnds.get("RDEC");
+		ReadEnd WE = readEnds.get("WE");
+		ReadEnd DEC = readEnds.get("DEC");
 		ReadEnd C = readEnds.get("C");
 		ReadWriteEnd Y = readWriteEnds.get("Y");
 
@@ -53,9 +54,9 @@ public class GUIAm2910RegCntr extends SimpleRectangularHardcodedGUIComponent
 		// TODO handle U/X/Z
 		if (oldCVal == ZERO && CVal == ONE)
 		{
-			if ((RDEC.getValue() == ZERO && RWE.getValue() == ONE) || _RLD.getValue() == ZERO)
+			if ((DEC.getValue() == ZERO && WE.getValue() == ONE) || _RLD.getValue() == ZERO)
 				System.arraycopy(D.getValues().getBits(), 0, QC, 0, 12);
-			else if (RWE.getValue() == ONE)
+			else if (WE.getValue() == ONE)
 			{
 				Bit carry = Bit.ZERO;
 				// TODO extract to helper. This code almost also exists in GUIinc12.
@@ -63,19 +64,8 @@ public class GUIAm2910RegCntr extends SimpleRectangularHardcodedGUIComponent
 				for (int i = 11; i >= 0; i--)
 				{
 					Bit a = QC[i];
-					Bit z;
-					if (a.isBinary() && carry.isBinary())
-					{
-						boolean aBool = a == ONE;
-						boolean carryBool = carry == ONE;
-						z = !aBool ^ carryBool ? ONE : ZERO;
-						carry = aBool || carryBool ? ONE : ZERO;
-					} else
-					{
-						carry = carry.join(a);
-						z = carry;
-					}
-					QC[i] = z;
+					QC[i] = a.xnor(carry);
+					carry = a.or(carry);
 				}
 			}
 		}