From a8e2524839d38d43271b0a998e529db407e92e00 Mon Sep 17 00:00:00 2001
From: Christian Femers <femers@in.tum.de>
Date: Tue, 3 Sep 2019 09:16:42 +0200
Subject: [PATCH] Reworked extension point because it behaved unnecessarily
 strange.

Works now.
---
 net.mograsim.logic.model.am2900/plugin.xml             | 10 ++++------
 net.mograsim.machine/plugin.xml                        |  2 +-
 ....machinedefinition.exsd => machine_definition.exsd} | 10 +++++-----
 3 files changed, 10 insertions(+), 12 deletions(-)
 rename net.mograsim.machine/schema/{net.mograsim.machine.machinedefinition.exsd => machine_definition.exsd} (88%)

diff --git a/net.mograsim.logic.model.am2900/plugin.xml b/net.mograsim.logic.model.am2900/plugin.xml
index 7cfe4a72..7a324ad9 100644
--- a/net.mograsim.logic.model.am2900/plugin.xml
+++ b/net.mograsim.logic.model.am2900/plugin.xml
@@ -2,13 +2,11 @@
 <?eclipse version="3.4"?>
 <plugin>
    <extension
-         id="net.mograsim.machine.machinedefinition.am2900"
-         name="Am2900 Machine"
-         point="net.mograsim.machine.machinedefinition">
-      <MachineDefinitionImplementation
+         point="net.mograsim.machine.machine_definition">
+      <machineDefinitionImplementation
             class="net.mograsim.logic.model.am2900.machine.Am2900MachineDefinition"
-            name="net.mograsim.logic.model.am2900.machine.am2900machinedefinition">
-      </MachineDefinitionImplementation>
+            unique_id="Am2900">
+      </machineDefinitionImplementation>
    </extension>
 
 </plugin>
diff --git a/net.mograsim.machine/plugin.xml b/net.mograsim.machine/plugin.xml
index 8f737144..8c71c6db 100644
--- a/net.mograsim.machine/plugin.xml
+++ b/net.mograsim.machine/plugin.xml
@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <?eclipse version="3.4"?>
 <plugin>
-   <extension-point id="net.mograsim.machine.machinedefinition" name="Mograsim Machine Definition" schema="schema/net.mograsim.machine.machinedefinition.exsd"/>
+   <extension-point id="machine_definition" name="Mograsim Machine Definition" schema="schema/machine_definition.exsd"/>>
 </plugin>
diff --git a/net.mograsim.machine/schema/net.mograsim.machine.machinedefinition.exsd b/net.mograsim.machine/schema/machine_definition.exsd
similarity index 88%
rename from net.mograsim.machine/schema/net.mograsim.machine.machinedefinition.exsd
rename to net.mograsim.machine/schema/machine_definition.exsd
index 43763a6e..e5e147bf 100644
--- a/net.mograsim.machine/schema/net.mograsim.machine.machinedefinition.exsd
+++ b/net.mograsim.machine/schema/machine_definition.exsd
@@ -3,7 +3,7 @@
 <schema targetNamespace="net.mograsim.machine" xmlns="http://www.w3.org/2001/XMLSchema">
 <annotation>
       <appinfo>
-         <meta.schema plugin="net.mograsim.machine" id="net.mograsim.machine.machinedefinition" name="Mograsim Machine Definition"/>
+         <meta.schema plugin="net.mograsim.machine" id="machine_definition" name="Mograsim Machine Definition"/>
       </appinfo>
       <documentation>
          Mograsim extension for defining a machine
@@ -18,7 +18,7 @@
       </annotation>
       <complexType>
          <choice minOccurs="1" maxOccurs="unbounded">
-            <element ref="MachineDefinitionImplementation"/>
+            <element ref="machineDefinitionImplementation"/>
          </choice>
          <attribute name="point" type="string" use="required">
             <annotation>
@@ -47,12 +47,12 @@
       </complexType>
    </element>
 
-   <element name="MachineDefinitionImplementation">
+   <element name="machineDefinitionImplementation">
       <complexType>
-         <attribute name="name" type="string" use="required">
+         <attribute name="unique_id" type="string" use="required">
             <annotation>
                <documentation>
-                  The machines name
+                  The machines id, this should be unique, but still readable
                </documentation>
             </annotation>
          </attribute>
-- 
2.17.1