Added a constructor for ModelSplitterParams; added a TODO

[Mograsim.git] / plugins / net.mograsim.plugin.core / src / net / mograsim / plugin / tables / mi / MnemonicEditingSupport.java

diff --git a/plugins/net.mograsim.plugin.core/src/net/mograsim/plugin/tables/mi/MnemonicEditingSupport.java b/plugins/net.mograsim.plugin.core/src/net/mograsim/plugin/tables/mi/MnemonicEditingSupport.java
index 765e434..7248f4f 100644 (file)
--- a/plugins/net.mograsim.plugin.core/src/net/mograsim/plugin/tables/mi/MnemonicEditingSupport.java
+++ b/plugins/net.mograsim.plugin.core/src/net/mograsim/plugin/tables/mi/MnemonicEditingSupport.java
@@ -6,7 +6,9 @@ import org.eclipse.jface.viewers.EditingSupport;
 import org.eclipse.jface.viewers.TableViewer;
 import org.eclipse.swt.SWT;
 
+import net.mograsim.machine.mi.MicroInstruction;
 import net.mograsim.machine.mi.MicroInstructionDefinition;
+import net.mograsim.machine.mi.parameters.MicroInstructionParameter;
 import net.mograsim.machine.mi.parameters.Mnemonic;
 import net.mograsim.machine.mi.parameters.MnemonicFamily;
 
@@ -23,8 +25,10 @@ public class MnemonicEditingSupport extends EditingSupport
                super(viewer);
                family = (MnemonicFamily) definition.getParameterClassifications()[index];
                editor = new ComboBoxCellEditor(viewer.getTable(), family.getStringValues(), SWT.READ_ONLY);
+               editor.setActivationStyle(
+                               ComboBoxCellEditor.DROP_DOWN_ON_TRAVERSE_ACTIVATION | ComboBoxCellEditor.DROP_DOWN_ON_PROGRAMMATIC_ACTIVATION
+                                               | ComboBoxCellEditor.DROP_DOWN_ON_MOUSE_ACTIVATION | ComboBoxCellEditor.DROP_DOWN_ON_KEY_ACTIVATION);
                this.index = index;
-               editor.setValidator(new MnemonicCellEditorValidator(family));
                this.provider = provider;
        }
 
@@ -43,14 +47,20 @@ public class MnemonicEditingSupport extends EditingSupport
        @Override
        protected Object getValue(Object element)
        {
-               return ((Mnemonic) ((InstructionTableRow) element).data.getParameter(index)).ordinal();
+               InstructionTableRow row = ((InstructionTableRow) element);
+               return ((Mnemonic) row.data.getCell(row.address).getParameter(index)).ordinal();
        }
 
        @Override
        protected void setValue(Object element, Object value)
        {
                InstructionTableRow row = ((InstructionTableRow) element);
-               row.data.setParameter(index, family.get((Integer) value));
+               MicroInstructionParameter[] params = row.data.getCell(row.address).getParameters();
+               Mnemonic newParam = family.get((Integer) value);
+               if (newParam.equals(params[index]))
+                       return;
+               params[index] = newParam;
+               row.data.setCell(row.address, MicroInstruction.create(params));
                provider.update(row.address);
        }